🗑️ Add deprecation warnings to .new and #starttls #119
+146
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
2 times, most recently
from
e479952 to
1319d2a
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
3 times, most recently
from
42a247d to
688fae2
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
from
688fae2 to
031fb0f
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
7 times, most recently
from
cf830ef to
6cea168
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
2 times, most recently
from
2141292 to
de2244e
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
from
de2244e to
dfffcfe
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
2 times, most recently
from
e31b14e to
782cea8
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
from
782cea8 to
56befa6
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
from
56befa6 to
0cd91b4
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
from
0cd91b4 to
06c3eba
Compare
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
from
06c3eba to
272a3a5
Compare
* `ssl` was renamed to `tls` in most places, with backwards compatible aliases. Using `ssl` does not print any deprecation warnings. Using both `tls` and `ssl` keywords raises an ArgumentError. * Preparing for a (backwards-incompatible) secure-by-default configuration, `Net::IMAP.default_tls` will determine the value for `tls` when no explicit port or tls setting is provided. Using port 143 will be insecure by default. Using port 993 will be secure by default. Providing no explicit port will use `Net::IMAP.default_tls` with the appropriate port. And providing any other unknown port will use `default_tls` with a warning. 🚧 TODO: should we use a different config var for default tls params when port is 993 and `tls` is unspecified? 🚧 TODO: should we use a different config var for choosing `tls` when `port` is non-standard vs choosing `port` and `tls` when neither are specified? 🚧 TODO: should we use a different var for `default_tls` be used to config params when port is 993 but tls is implicit? Another var?
nevans
force-pushed
the
deprecations-for-new-and-starttls
branch
from
272a3a5 to
3e070d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for a (backwards-incompatible) secure-by-default configuration, Net::IMAP.default_ssl will be used when no explicit port or TLS setting is provided.
TODO: should truthy default_ssl be used to config params when port is 993 but ssl is implicit? Another var?
Moved all deprecated option handling to DeprecatedClientOptions, which is prepended to Net::IMAP.
Additionally, split
initializeup into small helper methods making it easier to understand at a glance.This is a first step towards fixing #118.